refactor: standardize Mempool glass/Goggles category naming to 'spam'#12
Open
twofaktor wants to merge 1 commit into
Open
refactor: standardize Mempool glass/Goggles category naming to 'spam'#12twofaktor wants to merge 1 commit into
twofaktor wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR standardizes the naming of the arbitrary data embedding category across both Mempool Glass and Mempool Goggles.
The two components were using different identifiers for the same category: Mempool Glass uses
spam, while parts of the Mempool Goggles implementation still referenced it asdata. This inconsistency made the codebase harder to follow and maintain.This change aligns Mempool Goggles with the existing Mempool Glass naming by consistently using
spamthroughout both implementations.Changes
datacategory references in Mempool Goggles tospam.Result
Mempool Glass and Mempool Goggles now use the same category identifier (
spam) for arbitrary data embedding filters, improving consistency across the project, making the codebase easier to maintain, and reducing the risk of future inconsistencies.